Kafka handle position and commit offset on seek operations#3453
Open
ozangunalp wants to merge 4 commits into
Open
Kafka handle position and commit offset on seek operations#3453ozangunalp wants to merge 4 commits into
ozangunalp wants to merge 4 commits into
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #3453 +/- ##
============================================
+ Coverage 77.47% 77.87% +0.40%
- Complexity 3778 5619 +1841
============================================
Files 306 486 +180
Lines 12673 18774 +6101
Branches 1648 2312 +664
============================================
+ Hits 9818 14620 +4802
- Misses 2116 3017 +901
- Partials 739 1137 +398
🚀 New features to boost your workflow:
|
ozangunalp
force-pushed
the
kafka_commit_offsets_seek
branch
from
2635bae to
73b713b
Compare
3 tasks
ozangunalp
force-pushed
the
kafka_commit_offsets_seek
branch
from
73b713b to
3c58ca8
Compare
ozangunalp
force-pushed
the
kafka_commit_offsets_seek
branch
from
3c58ca8 to
63dfc6b
Compare
When seek(), seekToBeginning(), or seekToEnd() is called on the consumer, reset the commit handler's per-partition offset tracking.
…rror (ex. WakeupException)
ozangunalp
force-pushed
the
kafka_commit_offsets_seek
branch
from
63dfc6b to
249df9b
Compare
cescoffier
requested changes
Jul 8, 2026
cescoffier
left a comment
cescoffier
left a comment
Contributor
There was a problem hiding this comment.
Should KafkaCheckpointCommit also implement partitionsSeeked?
|
|
||
| @Override | ||
| public void partitionsSeeked(Collection<TopicPartition> partitions) { | ||
| delegate.partitionsSeeked(partitions); |
Contributor
There was a problem hiding this comment.
After a seek, the ordered groups for the affected partitions are holding a stale state (pending counts, buffered items). This could cause records from the new position to be incorrectly ordered or dropped if the group's pending counter is non-zero.
I think we should consider whether the ordered groups for sought partitions should be canceled and removed, similar to what partitionsRevoked does.
| public class KafkaThrottledLatestProcessedCommit extends ContextHolder implements KafkaCommitHandler { | ||
|
|
||
| private final Map<TopicPartition, OffsetStore> offsetStores = new HashMap<>(); | ||
| private final Set<TopicPartition> seekedPartitions = new HashSet<>(); |
Contributor
There was a problem hiding this comment.
Use a copy on write variant - HashSet is not thread-safe.
Collaborator
Author
There was a problem hiding this comment.
Like the offset stores, it is only accessed on the channel context
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
onPartitionsSeekedcallback toKafkaConsumerRebalanceListenerandpartitionsSeekedto KafkaCommitHandler interface. On seek operations, the Kafka consumer clears the poller buffer and callspartitionsSeekedon commit handlers.